[FFmpeg-devel] [PATCH v2] libavcodec: add tune_content option also for VP8.

[James Zern]

Hi,

On Wed, Feb 7, 2024 at 8:04 AM Dariusz Marcinkiewicz via ffmpeg-devel
<ffmpeg-devel at ffmpeg.org> wrote:
>
> This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx.
>

For the subject use '(libavcodec|avcodec|lavc)/libvpxenc: ...' to
better document what is being changed. See the history of the file for
examples.

> Changes since v1:
> - Put the new param initialzation in the right place,
> - Account for cases when the encoder's output is queued up.
>

This is better left as a comment in the thread. It will lose its
meaning when committed.

> Co-authored-by: Erik Språng <sprang at webrtc.org>
> Signed-off-by: Dariusz Marcinkiewicz <darekm at google.com>
> ---
>  doc/encoders.texi      |  7 ++++--
>  libavcodec/libvpxenc.c | 56 ++++++++++++++++++++++++++++++++++++++----

Please bump LIBAVCODEC_VERSION_MICRO in libavcodec/version.h.

>  2 files changed, 56 insertions(+), 7 deletions(-)
>
> diff --git a/doc/encoders.texi b/doc/encoders.texi
> index c9fe6d6143..2a9b38f62a 100644
> --- a/doc/encoders.texi
> +++ b/doc/encoders.texi
> @@ -2186,6 +2186,11 @@ Enable error resiliency features.
>  Increase sharpness at the expense of lower PSNR.
>  The valid range is [0, 7].
>
> + at item tune-content

Please match the vpxenc command line. They're separate, vp8 has
--screen-content-mode.