[FFmpeg-devel] [PATCH] avcodec/tiff: pass arguments to bytestream2_seek in the right order

Leo Izen leo.izen at gmail.com
Fri Feb 9 22:50:19 EET 2024


On 1/31/24 14:37, Leo Izen wrote:
> The function signature for bytestream2_seek is (gb, offset, whence);
> Before this patch, the code passed (gb, SEEK_SET, offset), which is
> incorrect.
> 
> Siged-off-by: Leo Izen <leo.izen at gmail.com>
> ---
>   libavcodec/tiff.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index adb49e4525..3ce441aa2c 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
> @@ -1701,7 +1701,7 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
>           break;
>       case TIFF_ICC_PROFILE:
>           gb_temp = s->gb;
> -        bytestream2_seek(&gb_temp, SEEK_SET, off);
> +        bytestream2_seek(&gb_temp, off, SEEK_SET);
>   
>           if (bytestream2_get_bytes_left(&gb_temp) < count)
>               return AVERROR_INVALIDDATA;

Will apply soon.

- Leo Izen (Traneptora)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240209/f450bcc0/attachment.sig>


More information about the ffmpeg-devel mailing list