[FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks
Michael Niedermayer
michael at niedermayer.cc
Wed Feb 14 20:38:28 EET 2024
On Tue, Feb 13, 2024 at 04:24:56PM -0500, Leo Izen wrote:
> Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk
> to PNG files, if present.
>
> Signed-off-by: Leo Izen <leo.izen at gmail.com>
> ---
> libavcodec/pngenc.c | 4 ++++
> 1 file changed, 4 insertions(+)
This seems to break:
--- ./tests/ref/fate/cover-art-mp3-id3v2-remux 2024-02-14 19:33:50.756012174 +0100
+++ tests/data/fate/cover-art-mp3-id3v2-remux 2024-02-14 19:36:59.150052682 +0100
@@ -1,5 +1,5 @@
-94946f0efd5f9bb0061ac1fbff7d731f *tests/data/fate/cover-art-mp3-id3v2-remux.mp3
-399346 tests/data/fate/cover-art-mp3-id3v2-remux.mp3
+0643e306430fbadeb1c89da6ab36a303 *tests/data/fate/cover-art-mp3-id3v2-remux.mp3
+399414 tests/data/fate/cover-art-mp3-id3v2-remux.mp3
#tb 0: 1/14112000
#media_type 0: audio
#codec_id 0: mp3
@@ -23,7 +23,7 @@
0, -353590, -353590, 368640, 417, 0x15848290, S=1, 10
1, 0, 0, 0, 208350, 0x291b44d1
2, 0, 0, 0, 15760, 0x71d5c418
-3, 0, 0, 0, 165671, 0x7c1c8070
+3, 0, 0, 0, 165739, 0x2e108b69
0, 15050, 15050, 368640, 418, 0x46f684a4
0, 383690, 383690, 368640, 418, 0x46f684a4
0, 752330, 752330, 368640, 418, 0x46f684a4
Test cover-art-mp3-id3v2-remux failed. Look at tests/data/fate/cover-art-mp3-id3v2-remux.err for details.
tests/Makefile:318: recipe for target 'fate-cover-art-mp3-id3v2-remux' failed
make: *** [fate-cover-art-mp3-id3v2-remux] Error 1
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20240214/ec181fbd/attachment.sig>
More information about the ffmpeg-devel
mailing list