[FFmpeg-devel] [PATCH 7/8] avformat/movenc: add support for Immersive Audio Model and Formats in ISOBMFF

James Almer jamrial at gmail.com
Tue Feb 20 16:47:07 EET 2024


On 2/20/2024 11:21 AM, Andreas Rheinhardt wrote:
> James Almer:
>> On 2/20/2024 10:37 AM, Andreas Rheinhardt wrote:
>>>> @@ -7862,7 +8087,7 @@ static int avif_write_trailer(AVFormatContext *s)
>>>>          // write extent offsets.
>>>>        pos_backup = avio_tell(pb);
>>>> -    for (i = 0; i < s->nb_streams; i++) {
>>>> +    for (i = 0; i < mov->nb_streams; i++) {
>>> Can you use loop-scope for all the iterators that you touch where
>>> possible, please?
>>
>> Can you elaborate?
> 
> Use "for (int i = 0;" when you already touch the line (where possible).
> 
> - Andreas

Done. Thanks.


More information about the ffmpeg-devel mailing list