[FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Feb 28 18:01:13 EET 2024


Niklas Haas:
> On Wed, 28 Feb 2024 16:45:50 +0100 Andreas Rheinhardt <andreas.rheinhardt at outlook.com> wrote:
>> I don't think this should be duplicated for every bitdepth.
> 
> To clarify, you think the bit depth should be just treated as a runtime
> parameter instead of this being a template at all? How would you suggest
> to handle the diference in pixel size between 8-bit and 10/12-bit?
> 
> Maybe a middle ground would be to compile this template only twice, once
> for HBD and once for 8-bit, with the HBD code-path taking the bitdepth
> as an extra parameter.

That's my preferred way.

> 
> (That's actually what dav1d does internally)



More information about the ffmpeg-devel mailing list