[FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

[Andreas Rheinhardt]

Niklas Haas:
> On Thu, 29 Feb 2024 13:33:36 +0100 Niklas Haas <ffmpeg at haasn.xyz> wrote:
>> +// Symbols that do not depend on bit depth
>> +#ifndef GRAIN_WIDTH
>> +# define GRAIN_WIDTH 82
>> +# define GRAIN_HEIGHT 73
>> +# define SUB_GRAIN_WIDTH 44
>> +# define SUB_GRAIN_HEIGHT 38
>> +# define FG_BLOCK_SIZE 32
>> +#endif
> 
> Decided to move these out of this template as well.
> 
> At what point would it be cleaner to introduce an
> <aom_film_grain_internal.h> just for these shared helpers / definitions
> live inside?

We will never have a public header (corresponding to <> instead of "")
for internal helpers.

Whether this should be put in a header of its own depends upon how many
different files use it. If the answer is "one" (as it seems to be now),
then there is no need for a header.

- Andreas