[FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

[Nuo Mi]

On Tue, Jan 2, 2024 at 11:51 PM Lynne <dev at lynne.ee> wrote:

> Jan 2, 2024, 10:48 by nuomi2021 at gmail.com:
>
> > On Mon, Jan 1, 2024 at 11:18 PM Lynne <dev at lynne.ee> wrote:
> >
> >> Jan 1, 2024, 15:15 by nuomi2021 at gmail.com:
> >>
> >> > Co-authored-by: Xu Mu <toxumu at outlook.com>
> >> > Co-authored-by: Frank Plowman <post at frankplowman.com>
> >> > Co-authored-by: Shaun Loo <shaunloo10 at gmail.com>
> >> > Co-authored-by: Wu Jianhua <toqsxw at outlook.com>
> >> > ---
> >> >  libavcodec/vvc/Makefile              |    1 +
> >> >  libavcodec/vvc/vvc_ctu.h             |    1 +
> >> >  libavcodec/vvc/vvc_filter.c          | 1332
> ++++++++++++++++++++++++++
> >> >  libavcodec/vvc/vvc_filter.h          |   71 ++
> >> >  libavcodec/vvc/vvc_filter_template.c | 1135 ++++++++++++++++++++++
> >> >  5 files changed, 2540 insertions(+)
> >> >  create mode 100644 libavcodec/vvc/vvc_filter.c
> >> >  create mode 100644 libavcodec/vvc/vvc_filter.h
> >> >  create mode 100644 libavcodec/vvc/vvc_filter_template.c
> >> >
> >>
> >> Is there really absolutely nothing you can reuse from the HEVC decoder?
> >>
> > LMCS and ALF are new filters. SAO is entirely reusable, and deblock is
> > partially reusable.
> > However, all of them require some changes to the HEVC code.
> > Currently, I prefer not to touch the HEVC code as there is no HEVC
> > maintainer, and any HEVC code change requires a very long review time.
> >
>
> I disagree with this. There doesn't need to be an HEVC maintainer to merge
> patches, many of us are experienced enough to review them.
> If this does not get done now, it will never get done, and it'll be a
> nightmare
> for someone trying to clean it up in 5 years.
>

Version 7.0 will be released in February. I hope we can include VVC decode.
I also want to give people some time to try and report issues about VVC.
Sending the VVC enabling patch set again may make the filter change
reviewer lose focus.
How about I merge this patch set today, and later, my first patch will
focus on fixing this.
I promise I won't make you wait for so long.
Thank you


> Particularly, we've been trying to clean up and deduplicate code and tables
> as much as possible in libavcodec, so I'd rather not have all our effort
> go to
> waste.
>
> Please, make them share the code. Put keep in in libavcodec/, since it's
> common to both.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>