[FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2

[aybe aybe]

Modern email clients like to do stuff they're told not to...

The link I meant previously: https://github.com/aybe/FFmpeg-PSX-STR-tests


------ Original Message ------
From "aybe aybe" <aybe.one-at-hotmail.com at ffmpeg.org<mailto:aybe.one-at-hotmail.com at ffmpeg.org>>
To "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org<mailto:ffmpeg-devel at ffmpeg.org>>
Date 1/16/2024 3:27:16 PM
Subject Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2

The new patch appears to work, stuff is synchronized, except:
- 30 FPS video still seen as 150FPS by VLC
- 15 FPS video emits tons of "[vost#0:0/rawvideo @ 000000000269b580] Clipping frame in rate conversion by 0.199989"

As for the corrupt samples, been able to find the original sources:

- the first is good old Descent
- was cut at exactly 2MB
- works in FFmpeg
- the second is Ridge Racer Type 4
- bad/incomplete extract with a tool that added "RIFF....CDXA" header for whatever reason
- does NOT work in FFmpeg, comprised of 38 audio streams + 2 video streams (only decodes some audio then aborts)
- but if I extract the relevant section from it, then works in FFmpeg

New videos, samples, logs:
https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faybe%2FFFmpeg-PSX-STR-tests&data=05%7C02%7C%7Cc7debed92bce42a5bcd908dc169f43bd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638410120640174537%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Faq1Hcn5X%2FVCvtVi5GO6Jes7mrPUCeZyrIZvDiAj6lw%3D&reserved=0

------ Original Message ------
From "Michael Niedermayer" <michael at niedermayer.cc<mailto:michael at niedermayer.cc><mailto:michael at niedermayer.cc>>
To "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org<mailto:ffmpeg-devel at ffmpeg.org><mailto:ffmpeg-devel at ffmpeg.org>>
Date 1/16/2024 12:42:49 AM
Subject Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mdec: DC reading for STRv1 is like STRv2

On Mon, Jan 15, 2024 at 04:14:46PM +0000, aybe aybe wrote:
Hi!

I just tried what you've suggested, using 150 and setting AVPacket->pts using sector MSF as LBA.

The results are somewhat mixed:

- NTSC video: A/V synchronized but is now seen as 120 FPS by VLC
- PAL video: A/V not synchronized anymore but still seen as 25 FPS by VLC

can you send the patch for this plus links to one sample for both cases ?

id like to take a look

thx

[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates