[FFmpeg-devel] [PATCH 1/4] lavu/float_dsp: add double-precision scalar product

[Alexander Strasser]

On 2024-05-29 18:51 +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit
> :
> > > +static double ff_scalarproduct_double_c(const double *v1,
>
> > Don't use an ff_ prefix for a static function.
>
> I can see over 300 such identifiers in the code base (many but not all inline),
> and I don't see why that would be a problem.

I agree that it's not a problem regarding on the functional side,
OTOH regarding coding conventions we try to consistently follow it's
misleading as the ff_ prefix indicates a bigger scope of sharing.

Maybe I'm missing something, but it looks to me that more than half of
those over 300 instances are correct (the inline ones in the headers).

I think Andreas remark is correct and it would be better to not use ff_
prefix wrongly when adding new code.


Best regards,
  Alexander

[...]