[FFmpeg-devel] [PATCH 03/10] avformat/mov: use 64bit for intermediate for rounding
Michael Niedermayer
michael at niedermayer.cc
Tue Mar 26 02:11:44 EET 2024
Fixes: signed integer overflow: 1768972133 + 968491058 cannot be represented in type 'int'
Fixes: 62276/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4802790784303104
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index f954b924a02..e5e704caeb1 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -8993,7 +8993,7 @@ static int mov_read_timecode_track(AVFormatContext *s, AVStream *st)
/* 60 fps content have tmcd_nb_frames set to 30 but tc_rate set to 60, so
* we multiply the frame number with the quotient.
* See tickets #9492, #9710. */
- rounded_tc_rate = (tc_rate.num + tc_rate.den / 2) / tc_rate.den;
+ rounded_tc_rate = (tc_rate.num + tc_rate.den / 2LL) / tc_rate.den;
/* Work around files where tmcd_nb_frames is rounded down from frame rate
* instead of up. See ticket #5978. */
if (tmcd_nb_frames == tc_rate.num / tc_rate.den &&
--
2.17.1
More information about the ffmpeg-devel
mailing list