[FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

[Eugene Zemtsov]

Any feedback?

On Thu, Oct 24, 2024 at 6:54 PM <ezemtsov at google.com> wrote:

> From: Eugene Zemtsov <eugene at chromium.org>
>
> Bug: https://issues.chromium.org/issues/372994341
> Change-Id: I695d625717c078ed6f84f44e58c34da858af4d3b
> Reviewed-on:
> https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5958151
> Reviewed-by
> <https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/5958151Reviewed-by>:
> Dale Curtis <dalecurtis at chromium.org>
> ---
>  libavformat/mov.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index b4390be44f..f213fd5b22 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -1672,6 +1672,8 @@ static int64_t get_frag_time(AVFormatContext *s,
> AVStream *dst_st,
>      // to fragments that referenced this stream in the sidx
>      if (sc->has_sidx) {
>          frag_stream_info = get_frag_stream_info(frag_index, index,
> sc->id);
> +        if (!frag_stream_info)
> +            return AV_NOPTS_VALUE;
>          if (frag_stream_info->sidx_pts != AV_NOPTS_VALUE)
>              return frag_stream_info->sidx_pts;
>          if (frag_stream_info->first_tfra_pts != AV_NOPTS_VALUE)
> --
> 2.47.0.163.g1226f6d8fa-goog
>
>

-- 
Thanks,
Eugene Zemtsov.