[FFmpeg-devel] [PATCH 2/2] avfilter/asrc_sine: correct accumulating phase error at every second

Nicolas George george at nsup.org
Thu Nov 7 17:14:52 EET 2024


Marton Balint (12024-11-06):
> This improves phase accuracy and for integer frequencies it makes the filter
> bitexact periodic per every second and completely eliminates accumulating
> errors.
> 
> This code intentionally uses the same counters as the beep support, so the
> additional overhead should be very minor.
> 
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
>  libavfilter/asrc_sine.c           |  6 ++-
>  tests/ref/fate/filter-concat      | 88 +++++++++++++++----------------
>  tests/ref/fate/filter-concat-vfr  | 88 +++++++++++++++----------------
>  tests/ref/fate/swr-async-firstpts |  2 +-
>  4 files changed, 94 insertions(+), 90 deletions(-)

Urgh, this is abominable.

NAK!

Regards,

-- 
  Nicolas George


More information about the ffmpeg-devel mailing list