[FFmpeg-devel] [PATCH] Fix incorrect enum type used for a local variable

[Eugene Zemtsov]

In order to reproduce the problem you need to compile with warnings as
errors and "enum-conversion" warning enabled.
This is the what clang complains about:

../../third_party/ffmpeg/libavcodec/decode.c:1469:60: error: implicit
conversion from enumeration type 'const enum AVPacketSideDataType' to
different enumeration type 'enum AVFrameSideDataType'
[-Werror,-Wenum-conversion]
 1469 |         const enum AVFrameSideDataType type_pkt   = map[i].packet;
      |                                        ~~~~~~~~     ~~~~~~~^~~~~~
../../third_party/ffmpeg/libavcodec/decode.c:1474:58: error: implicit
conversion from enumeration type 'const enum AVFrameSideDataType' to
different enumeration type 'enum AVPacketSideDataType'
[-Werror,-Wenum-conversion]
 1474 |         sd_pkt = packet_side_data_get(sd_src, nb_sd_src, type_pkt);
      |                  ~~~~~~~~~~~~~~~~~~~~                    ^~~~~~~~


On Fri, Nov 8, 2024 at 10:11 AM Marth64 <marth64 at proxyid.net> wrote:

> Eugene Zemtsov:
>
> LGTM. Is there a way to reproduce any bug that this fixes?
>
> Will test for side effects and wait for a few days in case anyone has
> comments or concerns.
>
> Thank you
>


-- 
Thanks,
Eugene Zemtsov.