[FFmpeg-devel] [PATCH v6 12/12] avfilter/vf_scale: switch to new swscale API

[Michael Niedermayer]

On Fri, Nov 15, 2024 at 12:11:34AM +0100, Niklas Haas wrote:
> On Fri, 15 Nov 2024 00:00:10 +0100 Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Tue, Nov 12, 2024 at 10:50:46AM +0100, Niklas Haas wrote:
> > > From: Niklas Haas <git at haasn.dev>
> > > 
> > > Most logic from this filter has been co-opted into swscale itself,
> > > allowing the resulting filter to be substantially simpler as it no
> > > longer has to worry about context initialization, interlacing, etc.
> > > 
> > > Sponsored-by: Sovereign Tech Fund
> > > Signed-off-by: Niklas Haas <git at haasn.dev>
> > > ---
> > >  libavfilter/vf_scale.c | 354 +++++++++--------------------------------
> > >  1 file changed, 72 insertions(+), 282 deletions(-)
> > 
> > ./ffmpeg -i foreman_cif.y4m  -vf scale=out_v_chr_pos=0:out_h_chr_pos=0 -f null -
> > 
> > [fc#-1 @ 0x55eec4ea3300] Error applying option 'out_v_chr_pos' to filter 'scale': Option not found
> > Error opening output file -.
> > Error opening output files: Option not found
> 
> I mean, this change is basically intentional. But I suppose I should add
> backwards compatibility code to at least round it to the nearest similar value.

yes, it should do something better than just failing with a message that confuses the user

also [fc#-1 @ 0x55b30de5f000] Error applying option 'in_v_chr_pos' to filter 'scale': Option not found
and others

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241115/94fe973b/attachment.sig>