[FFmpeg-devel] [PATCH 2/2] checkasm/aacencdsp: initialize AAC tables

[James Almer]

On 11/16/2024 11:50 AM, Rémi Denis-Courmont wrote:
> Le lauantaina 16. marraskuuta 2024, 16.39.29 EET James Almer a écrit :
>>> This a large proportion of values to underflow or overflow out of the int
>>> range. The C version then triggers Undefined Behaviour in that case by
>>> negating INT_MIN, so I don't suppose that that's correct.
>>
>> So is the C version broken, or this test's randomized values?
> 
> The C code ostensibly does not expect those values, but regardless I don't
> know if they can be triggered or not.
> 
> So I don't know if it's a bug in this patch, a bug in the C code or both.

Well, it can't be in this patch because i'm just initializing the 
encoder tables needed by the tested DSP functions. So if something is 
faulty, is the values generated by randomize_float() in this test.

I'm not sure how to constrain them, that said.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241116/54b0f651/attachment.sig>