[FFmpeg-devel] [PATCH v7 06/12] swscale: organize and better document flags

[Michael Niedermayer]

Hi


On Sat, Nov 16, 2024 at 12:25:01PM +0100, Niklas Haas wrote:
> From: Niklas Haas <git at haasn.dev>
> 
> Group them into an enum rather than random #defines, and document their
> behavior a bit more obviously.
> 

> Of particular note, I discovered that SWS_DIRECT_BGR is not referenced
> anywhere else in the code base. As such, I have moved it to the deprecated
> section, alongside SWS_ERROR_DIFFUSION.

The intend of SWS_DIRECT_BGR was to avoid a intermediate YUV
for RGB -> RGB rescaling. It indeed probably makes no sense in a new API
like that


"#defines" and enums are not exactly equivalent and could break some user apps
in theory

I think its probably ok but maybe should be documented in APIChanges or something

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If one takes all money from those who grow wealth and gives it to those who
do not grow wealth, 10 years later, almost the same people who where wealthy
will be wealthy again, the same people who where poor will be poor again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241121/c1149624/attachment.sig>