[FFmpeg-devel] [PATCH v2] swscale/ppc: disable YUV2RGB AltiVec acceleration

[Sean McGovern]

Hi Rémi,

On Mon, Nov 25, 2024, 13:02 Rémi Denis-Courmont <remi at remlab.net> wrote:

> Le sunnuntaina 24. marraskuuta 2024, 21.01.48 EET Sean McGovern a écrit :
> > The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform,
> > in both little- and big-endian configurations.
> >
> > Disable it by default.
> > Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re-enable it.
> > ---
> > v2: rebased over top of the recent swscale changes from Nik Haas
> > ---
> >  libswscale/ppc/yuv2rgb_altivec.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libswscale/ppc/yuv2rgb_altivec.c
> > b/libswscale/ppc/yuv2rgb_altivec.c index 57574c4ab3..f44733a880 100644
> > --- a/libswscale/ppc/yuv2rgb_altivec.c
> > +++ b/libswscale/ppc/yuv2rgb_altivec.c
> > @@ -558,6 +558,7 @@ av_cold SwsFunc ff_yuv2rgb_init_ppc(SwsInternal *c)
> >          if ((c->opts.src_h & 0x1) != 0)
> >              return NULL;
> >
> > +#ifdef SWS_USE_ALTIVEC_YUV2RGB
>
> TBH, I find this somwhat misleading as opposed to be a plain 'if 0' with a
> rationale comment.
>

I can do that but I feel like I would just be re-stating the commit message.

-- Sean McGovern