[FFmpeg-devel] [PATCH 2/2] doc/encoders: very basic FFv1 documentation

Anton Khirnov anton at khirnov.net
Thu Nov 28 15:29:54 EET 2024


Quoting Michael Niedermayer (2024-11-27 23:18:25)
> Hi
> 
> On Tue, Nov 26, 2024 at 11:48:54AM +0100, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-10-15 00:46:50)
> > > + at item qtable
> > > +-1 (default, automatic), 0 use 8bit default, 1, use >8bit default
> > 
> > int seems like the wrong type then.
> 
> well, you are correct, (maybe not they way you meant it)
> but as the encoder can choose any table of any values.
> an int is not able to convey that and something like a string would
> be better. Allowing explicit values as well as automcatic and specific
> named tables
> 
> Currently its an int though. And an enum may be undefined
> tha AVOption should maybe also have some named constants instead
> of 0,1
> 
> before i implement any of this, which direction was your comment
> meant to point to ?

My point was just that numeric values are cryptic, the user has to look
into the docs or code to understand what they mean.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list