[FFmpeg-devel] [PATCH 3/3] avformat/mov: Fix overflow in corrected_dts

[Michael Niedermayer]

Hi

On Fri, Nov 29, 2024 at 11:39:06PM -0300, James Almer wrote:
> On 11/29/2024 11:20 PM, Michael Niedermayer wrote:
> > This fix doesnt feel optimal, better fix is welcome
> 
> Would you be ok with the C23 stdckdint.h compat header patch i sent two
> months ago being committed and used for this kind of overflow?

> I ask because the only con from using it is that backports to existing
> branches will either require said header also being included in them, or a
> different fix being applied.

if you can backport this header and it works, thats probably a good solution

but this still leaves a question. What do we do in case of corrected_dts
overflows?
simply erroring out, would result in unplayable streams which may otherwise
play ok-ish
OTOH if we maybe just set corrected_dts to 0, is that better than just
what uint64 does ?

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241130/20796cd7/attachment.sig>