[FFmpeg-devel] [PATCH 12/12] swscale/input: parametrize ff_sws_init_input_funcs() pointers

Niklas Haas ffmpeg at haasn.xyz
Tue Oct 8 03:27:43 EEST 2024


On Mon, 07 Oct 2024 20:14:50 -0300 James Almer <jamrial at gmail.com> wrote:
> On 10/5/2024 4:24 PM, Niklas Haas wrote:
> > From: Niklas Haas <git at haasn.dev>
> > 
> > Following the precedent set by ff_sws_init_output_funcs().
> > 
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Niklas Haas <git at haasn.dev>
> > ---
> >   libswscale/input.c            | 388 +++++++++++++++++-----------------
> >   libswscale/swscale.c          |   3 +-
> >   libswscale/swscale_internal.h |   8 +-
> >   3 files changed, 206 insertions(+), 193 deletions(-)
> > 
> > diff --git a/libswscale/input.c b/libswscale/input.c
> > index d171394bb2..2a7a6c91dd 100644
> > --- a/libswscale/input.c
> > +++ b/libswscale/input.c
> > @@ -1285,86 +1285,92 @@ static void rgbaf16##endian_name##ToA_c(uint8_t *_dst, const uint8_t *_src, cons
> >   rgbaf16_funcs_endian(le, 0)
> >   rgbaf16_funcs_endian(be, 1)
> >   
> > -av_cold void ff_sws_init_input_funcs(SwsContext *c)
> > +av_cold void ff_sws_init_input_funcs(SwsContext *c,
> > +                                     planar1_YV12_fn *lumToYV12,
> > +                                     planar1_YV12_fn *alpToYV12,
> > +                                     planar2_YV12_fn *chrToYV12,
> > +                                     planarX_YV12_fn *readLumPlanar,
> > +                                     planarX_YV12_fn *readAlpPlanar,
> > +                                     planarX2_YV12_fn *readChrPlanar)
> 
> Is ff_sws_init_input_funcs() going to be called with function pointers 
> from other than the input SwsContext at some point?

The other functions will be used by my upcoming series. (ETA ~1 week)

This specific function is admittedly not yet used directly, but refactoring
input handling is next on my list for the ongoing rewrite.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list