[FFmpeg-devel] [PATCH 3/4] fftools/opt_common: stop accessing a private field

[Michael Niedermayer]

On Mon, Oct 14, 2024 at 01:36:46PM +0200, Anton Khirnov wrote:
> ---
>  fftools/opt_common.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index 021ed75272..34da2cee7d 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -808,7 +808,6 @@ int show_filters(void *optctx, const char *opt, const char *arg)
>      printf("Filters:\n"
>             "  T.. = Timeline support\n"
>             "  .S. = Slice threading\n"
> -           "  ..C = Command support\n"
>             "  A = Audio input/output\n"
>             "  V = Video input/output\n"
>             "  N = Dynamic number and/or type of input/output\n"
> @@ -833,10 +832,9 @@ int show_filters(void *optctx, const char *opt, const char *arg)
>                                    ( i && (filter->flags & AVFILTER_FLAG_DYNAMIC_OUTPUTS))) ? 'N' : '|';
>          }
>          *descr_cur = 0;
> -        printf(" %c%c%c %-17s %-10s %s\n",
> +        printf(" %c%c %-17s %-10s %s\n",
>                 filter->flags & AVFILTER_FLAG_SUPPORT_TIMELINE ? 'T' : '.',
>                 filter->flags & AVFILTER_FLAG_SLICE_THREADS    ? 'S' : '.',
> -               filter->process_command                        ? 'C' : '.',
>                 filter->name, descr, filter->description);
>      }
>  #else

The commit message is not describing this change accurately

Its not just "not accessing a priavte field", it removes information
from the printed filter list

Thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241014/9ce8c191/attachment.sig>