[FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

[Lynne]

On 15/10/2024 17:51, Lynne via ffmpeg-devel wrote:
> On 15/10/2024 16:49, David Rosca wrote:
>> Fixes leaking recon surfaces with VAAPI.
>> ---
>>   libavcodec/hw_base_encode.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c
>> index 7b6ec97d3b..912c707a68 100644
>> --- a/libavcodec/hw_base_encode.c
>> +++ b/libavcodec/hw_base_encode.c
>> @@ -804,6 +804,11 @@ int ff_hw_base_encode_init(AVCodecContext *avctx, 
>> FFHWBaseEncodeContext *ctx)
>>   int ff_hw_base_encode_close(FFHWBaseEncodeContext *ctx)
>>   {
>> +    FFHWBaseEncodePicture *pic;
>> +
>> +    for (pic = ctx->pic_start; pic; pic = pic->next)
>> +        base_encode_pic_free(pic);
>> +
>>       av_fifo_freep2(&ctx->encode_fifo);
>>       av_frame_free(&ctx->frame);
> 
> I've noticed this happening with Vulkan as well.
> 
> LGTM, I'll push this after testing it in a few hours
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Thanks, pushed
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241016/34b43e77/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241016/34b43e77/attachment.sig>