[FFmpeg-devel] [PATCH 1/6] avutil/pixfmt: add Y216 pixel format

James Almer jamrial at gmail.com
Tue Oct 22 17:38:03 EEST 2024


On 10/22/2024 11:45 AM, martin schitter wrote:
> 
> 
> On 22.10.24 15:10, James Almer wrote:
>> On 10/22/2024 11:26 AM, martin schitter wrote:
>>>
>>>
>>> On 22.10.24 14:48, James Almer wrote:
>>>> +    AV_PIX_FMT_Y216BE,      ///< packed YUV 4:2:2 like YUYV422, 
>>>> 32bpp, big-endian
>>>> +    AV_PIX_FMT_Y216LE,      ///< packed YUV 4:2:2 like YUYV422, 
>>>> 32bpp, little-endian
>>>
>>> Why to you avoid any more verbose naming, where any developer would 
>>> see the actual order of components by just looking at the actual 
>>> letters to avoid wrong usage?
>>
>> It's too late for that. This naming scheme goes back more than a 
>> decade. It would require a big, API breaking and disruptive overhaul 
>> to switch to one where the names follow the component order and bitdepth.
> 
> if you do a simple:
> 
>      ❯ rg "(YUYV|YVYU|UYVY|VYUY)" libavutil/pixfmt.h
> 
> you'll see, that the slightly more verbose variants were already 
> invented and used by clever developers long before us. :)

I am aware, which is why i named a recent one VYU444. But since Y21x 
already exist, I'm following the pattern for this one.

> 
> They build a very simple help to prevent stupid errors caused by 
> unavoidable presence of slightly different ordered but otherwise very 
> similar variants of packed 4:2:2 data.
> 
> martin
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241022/75f0312f/attachment.sig>


More information about the ffmpeg-devel mailing list