[FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

[Andreas Rheinhardt]

Timo Rothenpieler:
> These can easily lead to incredibly confusing errors, and should
> practically never happen.
> I'd have loved to make this a -Werror even, but sadly there is way too
> many instances in the codebase right now that first needs to be weeded
> out.

IMO these instances would need to be weeded out before this is enabled
even as a warning.

> ---
>  configure | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configure b/configure
> index a8e67d230c..547b67565d 100755
> --- a/configure
> +++ b/configure
> @@ -7406,6 +7406,7 @@ check_cflags -Wundef
>  check_cflags -Wmissing-prototypes
>  check_cflags -Wstrict-prototypes
>  check_cflags -Wempty-body
> +check_cflags -Wshadow
>  
>  if enabled extra_warnings; then
>      check_cflags -Wcast-qual