[FFmpeg-devel] [PATCH 1/4] avfilter/af_pan: Fix sscanf() use

Michael Niedermayer michael at niedermayer.cc
Tue Jan 7 01:23:17 EET 2025


Fixes: Memory Data Leak

Found-by: Simcha Kosman <simcha.kosman at cyberark.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavfilter/af_pan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c
index 0d20b0307b3..3a11a7d324f 100644
--- a/libavfilter/af_pan.c
+++ b/libavfilter/af_pan.c
@@ -196,7 +196,7 @@ static av_cold int init(AVFilterContext *ctx)
         sign = 1;
         while (1) {
             gain = 1;
-            if (sscanf(arg, "%lf%n *%n", &gain, &len, &len))
+            if (sscanf(arg, "%lf%n *%n", &gain, &len, &len) == 1)
                 arg += len;
             if (parse_channel_name(&arg, &in_ch_id, &named)){
                 av_log(ctx, AV_LOG_ERROR,
-- 
2.47.0



More information about the ffmpeg-devel mailing list