[FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

[Devin Heitmueller]

On Mon, Mar 3, 2025 at 7:25 AM Tomas Härdin <git at haerdin.se> wrote:
>
> Looking at CTA-708 at the moment and noticed this. In the future we
> might want to make it possible for the user to set the country code.
> This patch makes finding usage of the US country code easier

I've got no objection to moving a constant value to a #define for the
purpose of clarity, but there should never be a reason it needs to be
configurable by the user.  The country code to be used for CTA-708 is
defined by the standards authority and must be 0xb5 (just as the
provider code must be 0x31).  Even if the captions are intended to
serve other countries, the country code will stay the same (defining
the country code for individual languages goes in the PMT).

Devin

-- 
Devin Heitmueller, Senior Software Engineer
LTN Global Communications
o: +1 (301) 363-1001
w: https://ltnglobal.com  e: devin.heitmueller at ltnglobal.com