[FFmpeg-devel] [PATCH 1/2] avcodec/vc2enc: Use LUT to assemble interleaved golomb, code

[Lynne]

On 12/03/2025 04:10, Andreas Rheinhardt wrote:
> Patches attached.
> 
> - Andreas

First patch is wild, its surprising no one considered inverting the way 
decoder parses codes for an encoder yet.
Rather than ORing and using put_bits63, I think it would make more sense 
to write out each chunk using put_bits sequentially. It might be 
possible to reverse the lookups such that you get the MSBs first so you 
wouldn't need to reverse them out of place in a small array.
But either way, LGTM. Feel free to explore this in a follow-up.

Second patch seems a bit pointless. It's just one single call you're 
uninlining? Chasing to save a few extra bytes of binary surely don't 
deserve having a wrapper function for uninlining.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA2FEA5F03F034464.asc
Type: application/pgp-keys
Size: 624 bytes
Desc: OpenPGP public key
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250312/bea29af3/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250312/bea29af3/attachment.sig>