[FFmpeg-devel] [PATCH v8 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams

[Michael Niedermayer]

Hi Romain

On Sun, Mar 16, 2025 at 07:59:59PM -0500, Romain Beauxis wrote:
> Le dim. 16 mars 2025 à 19:20, Michael Niedermayer <michael at niedermayer.cc>
> a écrit :
> >
> > On Sat, Mar 15, 2025 at 07:08:05PM -0500, Romain Beauxis wrote:
> > > Hi all!
> > >
> > >
> > > Le jeu. 13 mars 2025 à 08:43, Michael Niedermayer
> > > <michael at niedermayer.cc> a écrit :
> > > >
> > > > Hi Romain
> > > >
> > > > On Tue, Mar 11, 2025 at 11:56:37AM -0500, Romain Beauxis wrote:
> > > > > Le mar. 11 mars 2025 à 11:55, Romain Beauxis
> > > > > <romain.beauxis at gmail.com> a écrit :
> > > > > >
> > > > > > This is a series of patches to allow proper decoding of ogg
> metadata in chained
> > > > > > `ogg/vorbis, `ogg/flac` and `ogg/opus` streams.
> > > > > >
> > > > > > ## Changes since last version:
> > > > > > * Moved textual reference output for tests to test/ref/fate
> > > > > > * Updated test binary to only output stream metadata when
> > > > > >   AVSTREAM_EVENT_FLAG_METADATA_UPDATED flag is set.
> > > > >
> > > > > Again, forgot to add that test samples are available here:
> > > > >
> https://www.dropbox.com/scl/fo/xrtrna2rxr1j354hrtymq/AGwemlxHYecBLNmQ8Fsy--4?rlkey=lzilr4m9w4gfdqygoe172vvy8&dl=0
> > >
> > > Any update on this? Or concerns re: the samples?
> > >
> > > I've got more work ready to send, I'd love to finish this patch set to
> > > get the next one rolling.
> >
> > the files contain "metadata: encoder=Lavc61.19.100"
> >
> > So they are version dependant which is a problem for reference files
> 
> Can you elaborate on that?
> 
> Vorbis comments standard requires that the encoder be the first comment in
> the comment block and that's the value.
> 
> The version written as the encoder is static metadata, I fail to see how it
> would change with any future version of libavc, it is just a marker of the
> version that was used when the file was created.
> 
> If that can help, I'm happy to update the files to show any other value for
> the encoder, though.

If its just teh version read from a file, then its fine.
The problem would be only if its the version of the code under test

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250320/fb3aeaea/attachment.sig>