[FFmpeg-devel] [PATCH 2/2] avformat/movenccenc: add support for CENC AV1 encryption

[Andreas Rheinhardt]

James Almer:
> On 3/20/2025 11:55 PM, Andreas Rheinhardt wrote:
>> Duplicating .o files is meant for small stuff, not for gigantic things
>> like cbs_av1.o (whose .text is 86519B here).
> 
> This feature requires complete frame and tile group parsing, which in
> turn requires complete sequence header parsing. The amount of work to
> get that much parsing code in lavf will be huge for little (if any) gain
> in total object size.
> 

a) Completely wrong: Approximately half of cbs_av1.o is code for writing
which lavf doesn't use.
b) Even the reading code is littered with CBS's tracing stuff which lavf
won't use.
c) There is also parsing stuff that won't be used.
d) Btw: Your patch shouldn't even compile in shared builds if the other
CBS modules are enabled as your lavf/cbs.o will try to pull in the other
ff_cbs_type_*.

- Andreas