[FFmpeg-devel] [PATCH v8 2/4] fftools/ffprobe: Change to use textformat api

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Soft
> Works
> Sent: Samstag, 22. März 2025 02:36
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v8 2/4] fftools/ffprobe: Change to
> use textformat api
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Samstag, 22. März 2025 02:23
> > To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v8 2/4] fftools/ffprobe: Change to
> > use textformat api
> >
> > On Wed, Mar 19, 2025 at 05:04:11PM +0000, softworkz wrote:
> > > From: softworkz <softworkz at hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz at hotmail.com>
> > > ---
> > >  fftools/Makefile  |   12 +
> > >  fftools/ffprobe.c | 1849 ++++--------------------------------------
> --
> > -
> > >  2 files changed, 142 insertions(+), 1719 deletions(-)
> >
> > seems to fail build on mingw64 (out of tree build)
> >
> > make -k
> > CC	fftools/textformat/avtextformat.o
> > src/fftools/textformat/avtextformat.c:672:1: fatal error: opening
> > dependency file fftools/textformat/avtextformat.d: No such file or
> > directory
> >   672 | }
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81:
> fftools/textformat/avtextformat.o]
> > Error 1
> > CC	fftools/textformat/tf_compact.o
> > src/fftools/textformat/tf_compact.c:282:1: fatal error: opening
> > dependency file fftools/textformat/tf_compact.d: No such file or
> > directory
> >   282 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_compact.o]
> > Error 1
> > CC	fftools/textformat/tf_default.o
> > src/fftools/textformat/tf_default.c:145:1: fatal error: opening
> > dependency file fftools/textformat/tf_default.d: No such file or
> > directory
> >   145 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_default.o]
> > Error 1
> > CC	fftools/textformat/tf_flat.o
> > src/fftools/textformat/tf_flat.c:174:1: fatal error: opening
> dependency
> > file fftools/textformat/tf_flat.d: No such file or directory
> >   174 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_flat.o]
> > Error 1
> > CC	fftools/textformat/tf_ini.o
> > src/fftools/textformat/tf_ini.c:160:1: fatal error: opening dependency
> > file fftools/textformat/tf_ini.d: No such file or directory
> >   160 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_ini.o]
> Error
> > 1
> > CC	fftools/textformat/tf_json.o
> > src/fftools/textformat/tf_json.c:214:1: fatal error: opening
> dependency
> > file fftools/textformat/tf_json.d: No such file or directory
> >   214 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_json.o]
> > Error 1
> > CC	fftools/textformat/tf_xml.o
> > src/fftools/textformat/tf_xml.c:220:1: fatal error: opening dependency
> > file fftools/textformat/tf_xml.d: No such file or directory
> >   220 | };
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tf_xml.o]
> Error
> > 1
> > CC	fftools/textformat/tw_avio.o
> > src/fftools/textformat/tw_avio.c:129:1: fatal error: opening
> dependency
> > file fftools/textformat/tw_avio.d: No such file or directory
> >   129 | }
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tw_avio.o]
> > Error 1
> > CC	fftools/textformat/tw_buffer.o
> > src/fftools/textformat/tw_buffer.c:92:1: fatal error: opening
> dependency
> > file fftools/textformat/tw_buffer.d: No such file or directory
> >    92 | }
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tw_buffer.o]
> > Error 1
> > CC	fftools/textformat/tw_stdout.o
> > src/fftools/textformat/tw_stdout.c:82:1: fatal error: opening
> dependency
> > file fftools/textformat/tw_stdout.d: No such file or directory
> >    82 | }
> >       | ^
> > compilation terminated.
> > make: *** [src/ffbuild/common.mak:81: fftools/textformat/tw_stdout.o]
> > Error 1
> > make: Target 'all' not remade because of errors.
> >
> 
> Seems like the same issue as the x86_32 build.
> Does it also happen when you do ./configure without cccache? (or maybe
> ccache --clear)
> 
> 

Or does it happen because of having down-tree items in the makefile?


OBJS-ffmpeg +=                        \
    fftools/ffmpeg_dec.o              \
    fftools/ffmpeg_demux.o            \
    fftools/objpool.o                 \
[..]
    fftools/ffmpeg_graphprint.o       \
    fftools/sync_queue.o              \
    fftools/thread_queue.o            \
    fftools/textformat/avtextformat.o \
    fftools/textformat/tf_compact.o   \
    fftools/textformat/tf_default.o   \
    fftools/textformat/tf_flat.o      \


Is it mandatory for some reason (other than clarity and modularity) to have a separate makefile in each subfolder?

Thanks
sw