[FFmpeg-soc] [soc]: r766 - qcelp/qcelpdec.c

Reynaldo Verdejo rverdejo at gmail.com
Tue Aug 14 18:24:22 CEST 2007


Hi Aurelien

On 8/14/07, Aurelien Jacobs <aurel at gnuage.org> wrote:

> > -        outbuffer[i]=av_clip(lrintf(4*ppf_vector[i]), -32768, 32767);
> > +        outbuffer[i]=av_clip(lrintf(4*ppf_vector[i]), -32768, 32768);
>
> This looks strange. The maximum 16bits signed integer is 32767, not 32768.


Fixed, thanks.

And if the range you want is indeed -32768 - 32767, you'd better use
> av_clip_int16().


It would be nice but I can't find it...

Thanks for your review

Reynaldo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070814/3e23cd3e/attachment.htm>


More information about the FFmpeg-soc mailing list