[FFmpeg-soc] [soc]: r815 - in dirac: ffmpeg.diff libavcodec/dirac.c

[Diego Biurrun]

On Wed, Aug 15, 2007 at 04:49:09PM +0200, Marco Gerards wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Aug 15, 2007 at 04:03:59PM +0200, marco wrote:
> >> 
> >> Log:
> >> basic code for the encoder
> >> 
> >> --- dirac/ffmpeg.diff	(original)
> >> +++ dirac/ffmpeg.diff	Wed Aug 15 16:03:59 2007
> >> @@ -2937,14 +2958,14 @@ AVCodec dirac_decoder = {
> >>  
> >> +#ifdef CONFIG_ENCODERS
> >> +AVCodec dirac_encoder = {
> >> +    "dirac",
> >> +    CODEC_TYPE_VIDEO,
> >> +    CODEC_ID_DIRAC,
> >> +    sizeof(DiracContext),
> >> +    encode_init,
> >> +    encode_frame,
> >> +    encode_end,
> >> +};
> >> +#endif
> >
> > The #ifdefs remind me: Please split the encoder off into a separate
> > file.
> 
> Would you mind if I waited a bit with this?  Because I am not familiar
> with encoders (and thus do not know which code can be shared), I do
> not actually know what should be split off.  So personally I rather
> wait a bit instead of moving functions back and forth.

I'm confident that the task is well within your capabilities :)

It's really not hard, move everything that is within CONFIG_ENCODERS
(which should really be CONFIG_DIRAC_ENCODER, btw) to a new file.  Do
the same for CONFIG_DECODERS, keep the rest in the common file.  If you
have trouble, we'll be here to give you a hand.

Diego