[FFmpeg-soc] vsrc_ppm

[Robert Swain]

On 20 Dec 2007, at 16:40, Bobby Bingham wrote:
> On Thu, 20 Dec 2007 15:17:29 +0100
> Vitor <vitor1001 at gmail.com> wrote:
>> diff -u libavfilter2/vf_overlay.c libavfilter/vf_overlay.c
>> --- libavfilter2/vf_overlay.c	2007-11-06 20:52:43.000000000
>> +0100
>> +++ libavfilter/vf_overlay.c	2007-12-20 13:59:45.000000000
>> +0100
>> @@ -141,7 +141,7 @@
>>      if(!over->pics[1][0]) return 1;
>>
>>      if(over->pics[0][0]->pts == over->pics[1][0]->pts) return 2;
>> -    return !!(over->pics[0][0]->pts < over->pics[1][0]->pts);
>> +    return (over->pics[0][0]->pts > over->pics[1][0]->pts);
>>  }
>
> Aren't these lines equivalent?

Erm, there are two ! but !!value when value is 0 or 1 anyway seems  
pointless. If the original code is correct, it seems to me that:

!!(over->pics[0][0]->pts < over->pics[1][0]->pts)

...is the same as...

over->pics[0][0]->pts < over->pics[1][0]->pts

...but Vitor changed the < to a >.

What is supposed to be going on here? :)

Rob
(I hope I didn't make a balls up there. :))