[FFmpeg-soc] [soc]: r308 - in dvbmuxer: mpeg_pes.h mpeg_pes_enc.c pes.c pes.diff pes.h pesenc.c

[Diego Biurrun]

On Tue, Jul 03, 2007 at 09:25:39AM +0200, realsun wrote:
> 
> Log:
> separate original patch into different patches
> fixes some cosmetic problems
> 
> --- (empty file)
> +++ dvbmuxer/mpeg_pes.h	Tue Jul  3 09:25:38 2007
> @@ -0,0 +1,157 @@
> +/*
> + * Copyright (c) 2000-2002 Fabrice Bellard.

nit: extra period

So who wrote this file?  Why are you crediting Fabrice?

Also, there should be a short, maybe even just one line like in most
other files, description of what the file is.

> +/**
> + * @file mpeg_pes.h
> + * PES packetizer api header.

API, remove the period.

> +/**
> + * Initialization of PES mux.

I prefer muxer to mux, same below.

> +/**
> + * Write packet into PES fifo.

FIFO

I notice I seem to have reviewed this on ffmpeg-devel already.  The same
comments apply.

> --- (empty file)
> +++ dvbmuxer/mpeg_pes_enc.c	Tue Jul  3 09:25:38 2007
> @@ -0,0 +1,299 @@
> +/*
> + * PES muxer.
> + * Copyright (c) 2000-2002 Fabrice Bellard.

nit: extra periods

Here you have a one line description, but again: Why are you crediting
Fabrice?

Diego