[FFmpeg-soc] [soc]: r309 - dirac/dirac.c

[Luca Barbato]

marco wrote:
> Author: marco
> Date: Tue Jul  3 19:57:05 2007
> New Revision: 309
> 
> Log:
> Some cleanups and added defaults from the spec.  Please don't review this code yet until I finished the cleanup.
> 

... Just some nits here and there

> +} transfer_func_t;

> +struct source_parameters
> +
> +struct sequence_parameters

> +struct decoding_parameters

Use a namespace (like dirac_)

> +/* Defaults for sequence parameters.  */
> +static const struct sequence_parameters sequence_parameters_defaults[13] =
> +{
> +    /* Width   Height   Chroma format   Depth  */
> +    {  640,    480,     2,              8  },
> +    {  176,    120,     2,              8  },
> +    {  176,    144,     2,              8  },
> +    {  352,    240,     2,              8  },
> +    {  352,    288,     2,              8  },
> +    {  704,    480,     2,              8  },
> +    {  704,    576,     2,              8  },
> +
> +    {  720,    480,     2,              8  },
> +    {  720,    576,     2,              8  },
> +    {  1280,   720,     2,              8  },
> +    {  1920,   1080,    2,              8  },
> +    {  2048,   1556,    0,              16 },
> +    {  4096,   3112,    0,              16 },
> +};

> +
> +/* Defaults for source parameters.  */
> +static const struct source_parameters source_parameters_defaults[13] =
> +{
> +    { 0, 1, 0, {30, 1},        {1, 1},   640,  480,  0, 0, 0,  255,   128,   254,   0, 0, 0.2126, 0.0722, TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {15000, 1001},  {10, 11}, 176,  120,  0, 0, 0,  255,   128,   254,   1, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {25, 2},        {12, 11}, 176,  144,  0, 0, 0,  255,   128,   254,   2, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {15000, 1001},  {10, 11}, 352,  240,  0, 0, 0,  255,   128,   254,   1, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {25, 2},        {12, 11}, 352,  288,  0, 0, 0,  255,   128,   254,   2, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {15000, 1001},  {10, 11}, 704,  480,  0, 0, 0,  255,   128,   254,   1, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {25, 2},        {12, 11}, 704,  576,  0, 0, 0,  255,   128,   254,   2, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +
> +    { 0, 1, 0, {24000, 1001},  {10, 11}, 720,  480,  0, 0, 16, 235,   128,   224,   1, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {35, 1},        {12, 11}, 720,  576,  0, 0, 16, 235,   128,   224,   2, 0, 0.299,  0.144,  TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {24, 1},        {1, 1},   1280, 720,  0, 0, 16, 235,   128,   224,   0, 0, 0.2126, 0.0722, TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {24, 1},        {1, 1},   1920, 1080, 0, 0, 16, 235,   128,   224,   0, 0, 0.2126, 0.0722, TRANSFER_FUNC_TV },
> +    { 0, 1, 0, {24, 1},        {1, 1},   2048, 1536, 0, 0, 0,  65535, 32768, 65534, 3, 0, 0.25,   0.25,   TRANSFER_FUNC_LINEAR },
> +    { 0, 1, 0, {24, 1},        {1, 1},   4096, 3072, 0, 0, 0,  65535, 32768, 65534, 3, 0, 0.25,   0.25,   TRANSFER_FUNC_LINEAR },
> +};


I'm not sure if using some macros would make thing more messy or maybe
help understanding.


> +static const transfer_func_t preset_transfer_func[4] =
                                                    ^^^
3 or 4?

> +{
> +    TRANSFER_FUNC_TV, TRANSFER_FUNC_TV, TRANSFER_FUNC_DCI_GAMMA
> +};


That's all for now.

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero