[FFmpeg-soc] [soc]: r316 - in libavfilter: avfilter.c avfilter.h filter_test.c vf_crop.c vo_sdl.c vsrc_dummy.c

[Michael Niedermayer]

Hi

On Thu, Jul 05, 2007 at 10:48:48PM +0200, koorogi wrote:
> Author: koorogi
> Date: Thu Jul  5 22:48:48 2007
> New Revision: 316
> 
> Log:
> Rework filter initialization sequence.  Now supports passing user parameters,
> querying supported colorspaces, etc.
[...]
> @@ -91,6 +92,7 @@ int avfilter_link(AVFilterContext *src, 
>                    AVFilterContext *dst, unsigned dstpad)
>  {
>      AVFilterLink *link;
> +    int *fmts[2], i, j;
>  

shouldnt this be enum PixelFormat ?


[...]
> +    src->filter->outputs[srcpad].config_props(link);
> +    dst->filter->inputs[dstpad].config_props(link);

nitpick:
src->filter->outputs[srcpad].config_props(link);
dst->filter-> inputs[dstpad].config_props(link);


[...]
> +int *avfilter_make_format_list(int len, ...)
> +{
> +    int *ret, i;
> +    va_list vl;
> +
> +    ret = av_malloc(sizeof(int) * (len + 1));
> +    va_start(vl, len);
> +    for(i = 0; i < len; i ++)
> +        ret[i] = va_arg(vl, int);
> +    va_end(vl);
> +    ret[len] = -1;

should this be PIX_FMT_NONE instead of -1?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070705/0b913ec1/attachment.pgp>