[FFmpeg-soc] [soc]: r339 - in eac3: ac3.c ac3.h ac3tab.c ac3tab.h eac3.h eac3_parser.c eac3dec.c ffmpeg.patch

[Michael Niedermayer]

Hi

On Sat, Jul 07, 2007 at 04:04:27PM +0200, bwolowiec wrote:
> Author: bwolowiec
> Date: Sat Jul  7 16:04:27 2007
> New Revision: 339
> 
> Log:
> This is main code of the E-AC3 decoder. It plays available from hd-dvd samples (http://www1.mplayerhq.hu/MPlayer/samples/evob/). Few extensions are lacking: AHT, Channel coupling, spectral extension and few smaller parts of code (because there are no samples).
> 
[...]
> +//BSI
> +    int strmtyp; // 2); ///< Stream type
> +    int substreamid; // 3); ///< Substream identification
> +    int frmsiz; // 11); ///< Frame size
> +    int fscod; // 2); ///< Sample rate code
> +    int fscod2; // 2); ///< Sample rate code 2
> +    int numblkscod; // 2); ///< Number of audio blocks
> +    int acmod; // 3); ///< Audio coding mode
> +    int lfeon; // 1); ///< Low frequency effect channel on
> +    int bsid; // 5); ///< Bit stream identification
> +    int dialnorm; // 5); ///<Dialogue normalization
> +    int compre; // 1); ///< Compression gain word exists
> +    int compr; // 8); ///< Compression gain word
> +    int dialnorm2; // 5); ///< Dialog normalization ch2
> +    int compr2e; // 1); ///< Compression gain word ch2 exists
> +    int compr2; // 8); ///< Compression gain word ch2
> +    int chanmape; // 1); ///< Custom channel map exists
> +    int chanmap; // 16); ///< Custom channel map
> +    int mixmdate; // 1); ///< Mixing meta-data exists

vertical align please


[...]
> +int eac3_parse_syncinfo(GetBitContext *gbc, EAC3Context *s);
> +int eac3_parse_bsi(GetBitContext *gbc, EAC3Context *s);
> +int eac3_parse_audfrm(GetBitContext *gbc, EAC3Context *s);
> +int eac3_parse_audblk(GetBitContext *gbc, EAC3Context *s, const int blk);
> +int eac3_parse_auxdata(GetBitContext *gbc, EAC3Context *s);

these either should be static or have a ff_ prefix


[...]
> +#ifdef DEBUG
> +#define GET_BITS(a, gbc, n) a = get_bits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a), a)
> +#else
> +#define GET_BITS(a, gbc, n) a = get_bits(gbc, n)

where is the problem with just using plain get_bits() and
if needed #define TRACE

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070711/93ad32fe/attachment.pgp>