[FFmpeg-soc] [soc]: r530 - matroska/matroskaenc.c

Michael Niedermayer michaelni at gmx.at
Thu Jul 26 03:02:31 CEST 2007


Hi

On Wed, Jul 25, 2007 at 05:56:05PM -0700, Mike Melanson wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Thu, Jul 26, 2007 at 02:05:30AM +0200, conrad wrote:
> >> Author: conrad
> >> Date: Thu Jul 26 02:05:30 2007
> >> New Revision: 530
> >>
> >> Log:
> >> Write the creation time
> > [...]
> >> @@ -526,6 +538,7 @@ static int mkv_write_header(AVFormatCont
> >>      if (!(s->streams[0]->codec->flags & CODEC_FLAG_BITEXACT)) {
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> >>          put_ebml_string(pb, MATROSKA_ID_MUXINGAPP , LIBAVFORMAT_IDENT);
> >>          put_ebml_string(pb, MATROSKA_ID_WRITINGAPP, LIBAVFORMAT_IDENT);
> >> +        put_ebml_date  (pb, MATROSKA_ID_DATEUTC   , av_gettime()     );
[...]
> And of even greater concern is the fact that it can make automated
> regression testing more difficult.

not in this case

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070726/c6418496/attachment.pgp>


More information about the FFmpeg-soc mailing list