[FFmpeg-soc] [soc]: r254 - matroska/matroskaenc.c

[Michael Niedermayer]

Hi

On Thu, Jun 14, 2007 at 03:19:46AM +0200, conrad wrote:
> Author: conrad
> Date: Thu Jun 14 03:19:46 2007
> New Revision: 254
> 
> Log:
> Correctly write CodecPrivate element for Vorbis and Theora

[...]

> +                codecprivate = start_ebml_master(pb, MATROSKA_ID_CODECPRIVATE);
> +                put_byte(pb, 2);                    // number packets - 1
> +                for (j = 0; j < 2; j++) {
> +                    for (k = 0; k < header_len[j] / 255; k++)
> +                        put_byte(pb, 255);
> +                    put_byte(pb, header_len[j]);

this looks buggy

header_len=255 would store
255, 255

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070614/c1b1a2d7/attachment.pgp>