[FFmpeg-soc] [soc]: r1341 - in eac3: eac3.h eac3dec.c

Justin Ruggles justinruggles at bellsouth.net
Thu Sep 13 05:25:16 CEST 2007

Diego Biurrun wrote:
> On Wed, Sep 12, 2007 at 09:53:51AM +0200, bwolowiec wrote:
>> @@ -1051,7 +1051,7 @@ static int parse_audblk(GetBitContext *g
>> -    for(ch=!s->cplinu[blk]; ch<=s->ntchans; ch++){
>> +    for(ch=!s->cplinu[blk]; ch<=s->num_channels; ch++){
>>          if(s->chexpstr[blk][ch]!=EXP_REUSE){
> Note that "for (" and "if (" is preferred.
> Diego

For as long as I've been a part of FFmpeg, there has never been any 
focus on small stylistic differences such as these, only on consistency. 
  I personally don't use spaces between my for's/if's/while's and the 
parentheses.  Nobody has ever called me out for it or suggested I change 
my coding style.


More information about the FFmpeg-soc mailing list