[FFmpeg-soc] [soc]: r1393 - in dirac/libavcodec: dirac.h diracdec.c diracenc.c

Michael Niedermayer michaelni at gmx.at
Mon Sep 24 16:40:02 CEST 2007


On Mon, Sep 24, 2007 at 04:37:07PM +0200, Marco Gerards wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> Hi,
> [...]
> >> Although my main concerns are with if I made the split correctly as in
> >> code wise.
> >
> > after a quick 10min look it looks ok ...
> Great, thanks for this effort :-)
> > one thing i spoted where that there are non static things in there without
> > a ff_ prefix but with just a dirac_ prefix these could break an application
> > which tries to link to both ffmpeg and the official dirac
> Yes, you are right.  At the same time I split the file, I introduced
> this namespace for non-static symbols.  I do not think the dirac_*
> names collide with those of the reference implementation, but I can
> not guarantee they won't.
> What would be a better prefix? dirac_ff_* or even ff_*?  Or just leave
> it as it is, until people start complaining?  Personally I do not care
> much about the prefix and will change it to whatever you like.

please use ff_dirac_* 

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070924/4bedb99d/attachment.pgp>

More information about the FFmpeg-soc mailing list