[FFmpeg-soc] [Patch] Maxis EA XA decoder - GSoC Task

Diego Biurrun diego at biurrun.de
Tue Apr 8 07:29:12 CEST 2008


On Tue, Apr 08, 2008 at 02:02:54AM +0200, Robert Marston wrote:
> On Tue, Apr 8, 2008 at 1:43 AM, Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Tue, Apr 08, 2008 at 01:36:04AM +0200, Robert Marston wrote:
> > >
> > > Attached are the patches for Maxis EA .XA file decoding. Was out of
> > > town for the weekend hence the late submission.
> > >
> > > Please comment on any improvements/errors?
> >
> > Please do not split this patch by file - nothing could be more
> > inconvenient.
> 
> Apologies, attached is one file with the changes.

Unfortunately you have not created a proper diff file.  Try applying it,
you will see that concatenating diffs with a C file does not create a
valid patch.

> > Next up: Lose all the tabs and trailing whitespace.
> 
> Tried to be pretty careful with this but may have let a few slip through.
> Any good way of checking this automatically?

Yes, there are plenty of ways, none of them really hard to figure out.
Consider it part of your qualification task :)

Diego



More information about the FFmpeg-soc mailing list