[FFmpeg-soc] [Patch] Maxis EA XA decoder - GSoC Task

[Robert Marston]

On Sun, Apr 13, 2008 at 7:21 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, Apr 13, 2008 at 06:38:27PM +0200, Robert Marston wrote:
>  > On Sun, Apr 13, 2008 at 12:41 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>  [...]
>
> > >  > +    int ret = 0;
>  > >  > +
>  > >  > +    if(xa->sent_bytes > xa->out_size)
>  > >  > +        return AVERROR(EIO);
>  > >  > +    /* 1 byte header and 14 bytes worth of samples * number channels per block */
>  > >  > +    packet_size = 15*st->codec->channels;
>  > >  > +
>  > >  > +    ret = av_get_packet(pb, pkt, packet_size);
>  > >
>  > >  ret is writen to twice but not read between.
>  [...]
>  > Corrected above issues.
>
> [...]
>  > +static int xa_read_packet(AVFormatContext *s,
>  > +                          AVPacket *pkt)
>  > +{
>  > +    MaxisXADemuxContext *xa = s->priv_data;
>  > +    AVStream *st = s->streams[0];
>  > +    ByteIOContext *pb = s->pb;
>  > +    unsigned int packet_size;
>
>  > +    int ret = 0;
>  > +
>  > +    if(xa->sent_bytes > xa->out_size)
>  > +        return AVERROR(EIO);
>  > +    /* 1 byte header and 14 bytes worth of samples * number channels per block */
>  > +    packet_size = 15*st->codec->channels;
>  > +
>  > +    ret = av_get_packet(pb, pkt, packet_size);
>
>  ret is still initialized twice
>

Apologies, misunderstood. Corrected.

Robert
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: maxis_ea_xa_format.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080413/fabbfbb0/attachment.txt>