[FFmpeg-soc] [PATCH] Taken out swscale_C.c and required swscale_yuv.h from nodame branch

Michael Niedermayer michaelni at gmx.at
Fri Aug 15 01:54:28 CEST 2008


On Thu, Aug 14, 2008 at 09:43:56PM +0200, Michael Niedermayer wrote:
> On Thu, Aug 14, 2008 at 05:49:25PM +0200, Keiji Costantini wrote:
> > this is the playground of swscale.
> > No arch specific things are here, just C code.
> > arch things are to be taken in after, when them are split between
> > bitexact and non-bitexact.
> > swscale_yuv.h is part of swscale.c (as in the nodame branch that part
> > was taken out)
> > -- 
> > Keiji Costantini
> >
> 
> > >From 3856f6000cf7842a139e4a89501caf8fab4b4208 Mon Sep 17 00:00:00 2001
> > From: Keiji Costantini <lists at strites.net>
> > Date: Wed, 13 Aug 2008 17:41:47 +0200
> > Subject: [PATCH] Taken out swscale_C.c and required swscale_yuv.h from nodame branch - this is the playground
> > 
> > ---
> >  swscale_C.c   | 1032 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  swscale_yuv.h |  551 ++++++++++++++++++++++++++++++
> >  2 files changed, 1583 insertions(+), 0 deletions(-)
> >  create mode 100644 swscale_C.c
> >  create mode 100644 swscale_yuv.h
> 
> patch rejected, i do not know what this is supposed to be.
> It certainly is not what i would call cleanup nor is it anthing
> that could be commited to main svn.
> Ive said many times that the code _MUST_ be in small and selfcontained
> changes and that asm code needs to be factorized out carefully and
> step by step. And that a rewrite is NOT acceptable nor wanted.
> Not to mention that even if this was split cleanly the changes itself
> would be almost entirely unacceptable.
> 
> Throwing all asm code away was NOT the goal of the cleanup project.

After reading my own reply, i realize that the words i have choosen where
rather harsh. This was not intended, iam sorry for that, but the issue that
the patches you posted are not enough remains.
Dont take it too serious and try to get healthy again, a flu in the summer
is really annoying ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080815/2d47bdae/attachment.pgp>


More information about the FFmpeg-soc mailing list