[FFmpeg-soc] [soc]: r3332 - mxf/mxfenc.c

Diego Biurrun diego at biurrun.de
Sun Aug 17 16:54:36 CEST 2008


On Sun, Aug 17, 2008 at 07:15:03PM +0800, zhentan feng wrote:
> 
> 2008/8/17 Diego Biurrun <diego at biurrun.de>
> 
> > On Sat, Aug 16, 2008 at 04:33:55AM +0200, spyfeng wrote:
> > >
> > > Log:
> > > modify struct componment references and instance uids
> >
> > This is a bad commit message just like
> >
> > i++; /* increase i */
> >
> > is a bad comment.
> >
> > It's plain to see that you modified certain things?  But in what
> > direction and why?  This is the relevant information...
> >
> I mean to change the way of building reference to make it simple and clear
> without malloc/free mem.

Then please make the commit message say this.

> I'll take care about this.

Please do, there are a handful of such commit messages from you.

Diego



More information about the FFmpeg-soc mailing list