[FFmpeg-soc] [soc]: r2802 - mxf/mxfenc.c

[Diego Biurrun]

On Wed, Jul 16, 2008 at 06:39:42PM +0200, spyfeng wrote:
> 
> Log:
> add file mxfenc.c for maintaince, debug, as base
> 
> --- (empty file)
> +++ mxf/mxfenc.c	Wed Jul 16 18:39:42 2008
> @@ -0,0 +1,930 @@
> +/*
> + * MXF muxer.

Lose the period.

> + * Copyright (c) 2008 GUCAS, Zhentan Feng<spyfeng at gmail dot com>.

ditto

> +static const uint8_t umid_base[] = {0x06, 0x0a, 0x2b, 0x34, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x0f, 0x00, 0x13, 0x00, 0x00, 0x00};//16 bytes
> +
> +/* complete key */
> +static const uint8_t op1a_ul[]            = { 0x06, 0x0e, 0x2b, 0x34, 0x04, 0x01, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x01, 0x01, 0x00 };
> +static const uint8_t header_partition_key[]            = { 0x06, 0x0e, 0x2b, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x02, 0x04, 0x00 };//ClosedComplete
> +static const uint8_t footer_partition_key[] = {0x06, 0x0e, 0x2b, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x04, 0x04, 0x00};//ClosedComplete
> +static const uint8_t primer_pack_key[] = { 0x06,0x0E,0x2B,0x34,0x02,0x05,0x01,0x01,0x0d,0x01,0x02,0x01,0x01,0x05,0x01,0x00 };

All these tables would be more readable with shorter lines, spaces after
the comma and nicely aligned.

> +    company_name_len = utf8len("FFmpeg") + 1;
> +    product_name_len = utf8len("OP1a Muxer") + 1;
> +    version_string_len = utf8len("version 0.0.1") + 1;

This could be aligned.

> +    if (mxf_generate_reference(s, set_ref->structural_component[stream_index], 1) < 0)

"if (" or

> +    if(ret < 0)

"if("?  Settle on one.

> +static int mxf_build_strctural_metadata(AVFormatContext *s, KLVPacket* klv, enum MXFMetadataSetType type)

strUctural

> +AVOutputFormat mxf_muxer = {
> +    "mxf",
> +    "material exchange file fromat",

This is wrong, see the mxf demuxer in the FFmpeg repo.

Diego