[FFmpeg-soc] [soc]: r2900 - mxf/mxfenc.c

Aurelien Jacobs aurel at gnuage.org
Tue Jul 29 19:31:04 CEST 2008


spyfeng wrote:

> Author: spyfeng
> Date: Tue Jul 29 18:28:24 2008
> New Revision: 2900
> 
> Log:
> remove utf8len() and use strlen() instead.
> 
> [...]
> 
> @@ -476,7 +466,7 @@ static int mxf_write_identification(AVFo
>      put_buffer(pb, "OP1a Muxer", product_name_len);
>  
>      mxf_write_local_tag(pb, version_string_len, 0x3C04);
> -    put_buffer(pb, "version 0.0.1", version_string_len);
> +    put_buffer(pb, "LIBAVFORMAT_IDENT", version_string_len);

This change is not exactly related to this commit.
Moreover, you don't want the " around the LIBAVFORMAT_IDENT...
And you should not use LIBAVFORMAT_IDENT when CODEC_FLAG_BITEXACT
is set (to allow constants regression tests). See other muxers
(such as matroskaenc.c) for example of this.

Aurel



More information about the FFmpeg-soc mailing list