[FFmpeg-soc] [soc]: r2903 - mxf/mxfenc.c

[Diego Biurrun]

On Tue, Jul 29, 2008 at 10:40:54AM -0700, Baptiste Coudurier wrote:
> 
> spyfeng wrote:
> > 
> > Log:
> > change lower case to upper case of the keys
> > 
> > --- mxf/mxfenc.c	(original)
> > +++ mxf/mxfenc.c	Tue Jul 29 19:01:20 2008
> > @@ -101,22 +101,22 @@ typedef struct {
> >  
> >  /* complete key */
> > -static const uint8_t op1a_ul[]            = { 0x06, 0x0e, 0x2b, 0x34, 0x04, 0x01, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x01, 0x01, 0x00 };
> > -static const uint8_t header_partition_key[]            = { 0x06, 0x0e, 0x2b, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x02, 0x04, 0x00 }; // ClosedComplete
> > -static const uint8_t footer_partition_key[] = {0x06, 0x0e, 0x2b, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0d, 0x01, 0x02, 0x01, 0x01, 0x04, 0x04, 0x00}; // ClosedComplete
> > -static const uint8_t primer_pack_key[] = { 0x06,0x0E,0x2B,0x34,0x02,0x05,0x01,0x01,0x0d,0x01,0x02,0x01,0x01,0x05,0x01,0x00 };
> > +static const uint8_t op1a_ul[]            = { 0x06, 0x0E, 0x2B, 0x34, 0x04, 0x01, 0x01, 0x01, 0x0D, 0x01, 0x02, 0x01, 0x01, 0x01, 0x01, 0x00 };
> > +static const uint8_t header_partition_key[]            = { 0x06, 0x0E, 0x2B, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0D, 0x01, 0x02, 0x01, 0x01, 0x02, 0x04, 0x00 }; // ClosedComplete
> > +static const uint8_t footer_partition_key[] = {0x06, 0x0E, 0x2B, 0x34, 0x02, 0x05, 0x01, 0x01, 0x0D, 0x01, 0x02, 0x01, 0x01, 0x04, 0x04, 0x00}; // ClosedComplete
> > +static const uint8_t primer_pack_key[] = { 0x06,0x0E,0x2B,0x34,0x02,0x05,0x01,0x01,0x0D,0x01,0x02,0x01,0x01,0x05,0x01,0x00 };
> 
> Vertically align these.
> You can remove spaces between numbers if you want, key are already long
> enough.

Please keep the spaces and break the lines instead.  The spaces make it
much more readable IMO.

Diego