[FFmpeg-soc] [soc]: r2276 - in wmapro: . wma3dec.c

[Sascha Sommer]

Hi,

On Freitag, 30. Mai 2008, Diego Biurrun wrote:
> On Fri, May 30, 2008 at 05:25:21PM +0200, faust3 wrote:
> > Log:
> > imported wmapro packet parser from the codecs repository
>
> Does it already work?
>

The file has not been written by me I therefore imported it in its original 
form but I think it should work. Benjamin showed me its output on Linuxtag 
yesterday.
 
> > --- (empty file)
> > +++ wmapro/wma3dec.c	Fri May 30 17:25:21 2008
> > @@ -0,0 +1,244 @@
> > +
> > +AVCodec wmav3pro_decoder =
> > +{
> > +    "wmav3Pro",
>
> Is there a difference between wmav3 and wmav3pro?  Version 1 and 2 are
> called wmav1/wmav2, so I think you should be consistent.

There also is a lossless variant for wmav3 so I think the distinction is 
needed. We can still change it before the decoder gets imported into the main 
svn.

>
> Also, the codec long name is missing.
>

I'll add that soon. See my first comment.

Regards

Sascha