[FFmpeg-soc] expand filter (alternative to pad syntax)

[Michael Niedermayer]

On Sat, May 31, 2008 at 11:40:21AM +0200, Vitor Sessak wrote:
> Michael Niedermayer wrote:
> > On Fri, May 30, 2008 at 06:30:21PM +0200, Vitor Sessak wrote:
> > [...]
> >>> (5) I have not resolved the issue of removing memcpy. There is only one 
> >>> call to memcpy in the code; to get rid of it is likely to require some 
> >>> significant change to the avfilter API, that will have to involve Vitor. 
> >>> In these circumstances, I wonder whether it would make sense to commit 
> >>> the code to SOC anyway, and then remove the one call to memcpy when 
> >>> we'll know how. (Observe that this situation is common to several filters.)
> >> I've discussed it a little with vmrsss in pvt and I think the solution 
> >> to it would be to negotiate the link dimensions during graph creation as 
> >> we do for pix_fmt. But after this is done, the changes to make vf_pad.c 
> >> memcpy-less would be rather minor, so I think this filter is better 
> >> commited to the soc tree (after review) instead of bitrotting as a patch 
> >> in the mailing list.
> > 
> > as i said i dont mind it being commited to soc
> > i do mind it being commited to ffmpeg-svn before the issue is solved.
> 
> I know. But since I plan getting all the filters from soc into ffmpeg 
> svn one day, I do care if there is anything other than the memcpy that 
> is not svn-ready. Also, what do you think of the idea of buffer size 
> negotiation (in the same way we do pixfmt negotiation)? I'll quote what 
> I worte to vmrsss in pvt:

What effect would that have on a decoder changing the output image size?
Also what about 
- int (*request_frame)(AVFilterLink *link);
+ int (*request_frame)(AVFilterLink *link, int width, int height, int left, int top);

where left/top is extra memory being allocated ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20080531/74dedb34/attachment.pgp>